On Wed, Oct 25, 2023 at 1:50 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > It would be better to gauge its value separately and add it once the > main patch is committed. > There should be a way to avoid this but we can decide it afterwards. I > don't want to hold the main patch for this point. What do you think?
+1 to go with the main patch first. We also have another thing to take care of - pg_upgrade option to not migrate logical slots. > > How about using "logical slots" in place of "logical replication > > slots" to be more generic? We agreed and changed the function name to > > > > Yeah, I am fine with that and I can take care of it before committing > unless there is more to change. +1. I have no other comments. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
