On Mon, Mar 27, 2023 at 11:08 AM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > The v9 patch was failing because I was using MyReplicationSlot after > it got reset by slot release, attached v10 patch fixes it. >
+ * + * Note: use LogReplicationSlotAcquire() if needed, to log a message after + * acquiring the replication slot. */ void ReplicationSlotAcquire(const char *name, bool nowait) @@ -542,6 +554,9 @@ retry: When does it need to be logged? For example, recently, we added one more slot acquisition/release call in binary_upgrade_logical_slot_has_caught_up(); it is not clear from the comments whether we need to LOG it or not. I guess at some place like atop LogReplicationSlotAcquire() we should document in a bit more specific way as to when is this expected to be called. -- With Regards, Amit Kapila.
