On Wed, Nov 01, 2023 at 10:39:04PM -0400, Tom Lane wrote: > Nathan Bossart <nathandboss...@gmail.com> writes: >> What if we disallowed NULL string GUCs in v17? > > Well, we'd need to devise some other solution for hacks like the > one used by timezone_abbreviations (see comment in > check_timezone_abbreviations). I think it's not worth the trouble, > especially seeing that 95% of guc.c is already set up for this. > The bugs are mostly in newer code like get_explain_guc_options, > and I think that's directly traceable to the lack of any comments > or docs about this behavior.
Eh, yeah, it's probably not worth it if we find ourselves trading one set of hacks for another. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
