On 2018-Jun-05, Daniel Gustafsson wrote: > > On 5 Jun 2018, at 16:31, Andrew Dunstan <andrew.duns...@2ndquadrant.com> > > wrote: > > > The patch contains a simple script to run the checks. The code that finds > > perl files is put in a function in a single file that is sourced by the > > three locations that need it. > > +1 on centralizing the find-files function.
+1 on that. Why do we need to make the new find_perl_files file executable, given it's always sourced? (I would have given a .sh extension because it's a lib not an executable, but I suppose that's just matter of taste; we certainly don't have a policy about it). Looks fine to me either way. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
