On 2023-Nov-21, Tom Lane wrote:

> Alvaro Herrera <alvhe...@alvh.no-ip.org> writes:
> > Right.  I made a few more adjustments, including the additional overflow
> > check in printTableInit that Tom Lane suggested, and pushed this.
> 
> Committed patch LGTM.

Thanks for looking!

> > It's a bit annoying that the error recovery decision of this code is to
> > exit the process with an error.  [...]
> > TBH though, I've never hit that code in real usage.
> 
> Yeah, I think the reason it's stayed like that for 25 years is that
> nobody's hit the case in practice.  Changing the API would be a bit
> troublesome, too, because we don't know if anybody besides psql
> uses it.

True.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/


Reply via email to