Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> writes: > A nitpick on the patch - how about honoring the passed-in parameter > with something like $self->{query_timer_restart} = 1 if !defined > $self->{query_timer_restart}; instead of just setting it to 1 (a value > other than undef) $self->{query_timer_restart} = 1;?
I wondered about that too, but the evidence of existing callers is that nobody cares. If we did make the code do something like that, (a) I don't think your fragment is right, and (b) we'd need to rewrite the function's comment to explain it. I'm not seeing a reason to think it's worth spending effort on. regards, tom lane