On Wed, Nov 29, 2023 at 7:48 PM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > On Wed, Nov 29, 2023 at 1:49 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > On Wed, Nov 29, 2023 at 4:30 PM Bharath Rupireddy > > <bharath.rupireddyforpostg...@gmail.com> wrote: > > > > > > On Tue, Nov 28, 2023 at 12:23 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > > > > > > > > Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> writes: > > > > > A nitpick on the patch - how about honoring the passed-in parameter > > > > > with something like $self->{query_timer_restart} = 1 if !defined > > > > > $self->{query_timer_restart}; instead of just setting it to 1 (a value > > > > > other than undef) $self->{query_timer_restart} = 1;? > > > > > > > > I wondered about that too, but the evidence of existing callers is > > > > that nobody cares. If we did make the code do something like that, > > > > (a) I don't think your fragment is right, and (b) we'd need to rewrite > > > > the function's comment to explain it. I'm not seeing a reason to > > > > think it's worth spending effort on. > > > > Agreed. > > > > > Hm. I don't mind doing just the $self->{query_timer_restart} = 1; like > > > in Sawada-san's patch. > > > > Okay, I've attached the patch that I'm going to push through v16, > > barring any objections. > > How about the commit message summary 'Fix TAP function > set_query_timer_restart() issue without argument.'? Also, it's good to > specify the commit 664d7575 that introduced the TAP function in the > commit message description.
Thanks! I've incorporated your comment and pushed the patch. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com