I found a few places where access/xlog_internal.h was apparently
included unnecessarily. In some of those places, a more specific header
file (that somehow came in via access/xlog_internal.h) can be used
instead. The *.h file change passes headerscheck.From c03641b59ec9575e74fa8eb4e519b59d548730af Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <pe...@eisentraut.org>
Date: Fri, 8 Dec 2023 12:25:51 +0100
Subject: [PATCH] Remove some unnecessary includes of "access/xlog_internal.h"
---
src/bin/pg_checksums/pg_checksums.c | 2 +-
src/bin/pg_rewind/timeline.c | 1 -
src/include/access/generic_xlog.h | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/bin/pg_checksums/pg_checksums.c
b/src/bin/pg_checksums/pg_checksums.c
index 6543d9ce08..19c083be17 100644
--- a/src/bin/pg_checksums/pg_checksums.c
+++ b/src/bin/pg_checksums/pg_checksums.c
@@ -20,11 +20,11 @@
#include <sys/stat.h>
#include <unistd.h>
-#include "access/xlog_internal.h"
#include "common/controldata_utils.h"
#include "common/file_perm.h"
#include "common/file_utils.h"
#include "common/logging.h"
+#include "common/relpath.h"
#include "fe_utils/option_utils.h"
#include "getopt_long.h"
#include "pg_getopt.h"
diff --git a/src/bin/pg_rewind/timeline.c b/src/bin/pg_rewind/timeline.c
index 2d445dac32..fd5f748448 100644
--- a/src/bin/pg_rewind/timeline.c
+++ b/src/bin/pg_rewind/timeline.c
@@ -10,7 +10,6 @@
#include "postgres_fe.h"
#include "access/timeline.h"
-#include "access/xlog_internal.h"
#include "pg_rewind.h"
/*
diff --git a/src/include/access/generic_xlog.h
b/src/include/access/generic_xlog.h
index 66941f99a8..f099ec7321 100644
--- a/src/include/access/generic_xlog.h
+++ b/src/include/access/generic_xlog.h
@@ -15,7 +15,7 @@
#define GENERIC_XLOG_H
#include "access/xlog.h"
-#include "access/xlog_internal.h"
+#include "access/xlogreader.h"
#include "access/xloginsert.h"
#include "storage/bufpage.h"
#include "utils/rel.h"
--
2.43.0
