Hi,
Here is the summary of the open-items, it would be great that Andres and Matthias have a look at this when they have time. 1. Shall we treat the LockBufHdr as a SpinLock usage. >> The LockBufHdr also used init_local_spin_delay / perform_spin_delay >> infrastruce and then it has the same issue like ${subject}, it is pretty >> like the code in s_lock; Based on my current knowledge, I think we >> should add the check there. > > I'd like to hear from Andres, if possible. @Andres: Should these > sanity checks apply only to spin locks per se, or also to buffer > header locks? > 2. Where shall we put the START/END_SPIN_LOCK() into? Personally I'd like spin.h. One of the reasons is 'misc' usually makes me think they are something not well categoried, and hence many different stuffs are put together. >> they were put into spin.h in v1 but later move to miscadmin.h at [1]. >> [1] >> https://www.postgresql.org/message-id/CAEze2WggP-2Dhocmdhp-LxBzic%3DMXRgGA_tmv1G_9n-PDt2MQg%40mail.gmail.com > > I'm not entirely sure what the right thing to do is here, and the > answer may depend on the previous question. But I disagree with > Matthias -- I don't think miscadmin.h can be the right answer > regardless. > -- Best Regards Andy Fan