Hi, > > Anyway, v2-0001 below is the previous patch rebased up to current > > (only line numbers change), and then v2-0002 responds to your > > and Daniel's review comments. > > LGTM.
``` +SELECT to_timestamp('2011-12-18 11:38 JUNK', 'YYYY-MM-DD HH12:MI TZ'); -- error +ERROR: invalid value "JUNK" for "TZ" +DETAIL: Time zone abbreviation is not recognized. +SELECT to_timestamp('2011-12-18 11:38 ...', 'YYYY-MM-DD HH12:MI TZ'); -- error +ERROR: invalid value ".." for "TZ" ``` Shouldn't the second error display the full value "..." (three dots) similarly to the previous one? Also I think we need at least one negative test for OF. Other than that v2 looks OK. -- Best regards, Aleksander Alekseev