On Mon, Jan 22, 2024 at 04:36:27PM +0900, Michael Paquier wrote:
> + if (ControlFile->backupStartPoint != InvalidXLogRecPtr)
>
> Nit 1: I would use XLogRecPtrIsInvalid here.
>
> + ereport(LOG,
> + (errmsg("completed backup recovery with redo LSN %X/%X",
> + LSN_FORMAT_ARGS(oldBackupStartPoint))));
>
> Nit 2: How about adding backupEndPoint in this LOG? That would give:
> "completed backup recovery with redo LSN %X/%X and end LSN %X/%X".Hearing nothing, I've just applied a version of the patch with these two modifications on HEAD. If this needs tweaks, just let me know. -- Michael
signature.asc
Description: PGP signature
