Re: A compiling warning in jsonb_populate_record_valid

[Tom Lane]

Amit Langote <amitlangot...@gmail.com> writes:
> On Thu, Jan 25, 2024 at 2:59 PM Richard Guo <guofengli...@gmail.com> wrote:
>> I came across a warning when building master (a044e61f1b) on old GCC
>> (4.8.5).

> Will apply the attached, which does this:

> -   return BoolGetDatum(!SOFT_ERROR_OCCURRED(&escontext));
> +   return BoolGetDatum(!escontext.error_occurred);

-1 please.  We should not break that abstraction for the sake
of ignorable warnings on ancient compilers.

                        regards, tom lane