Hi,
On Thu, Jan 25, 2024 at 01:11:50PM +0000, Zhijie Hou (Fujitsu) wrote:
> Here is the V69 patch set which includes the following changes.
>
> V69-0001, V69-0002
> 1) Addressed Bertrand's comments[1].
Thanks!
V69-0001 LGTM.
As far V69-0002 I just have one more last remark:
+ */
+ if (sub->enabled)
+ ereport(ERROR,
+
(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
+ errmsg("cannot
set %s for enabled subscription",
+
"failover")));
Worth to add a test for it in 050_standby_failover_slots_sync.pl? (I had a quick
look and it does not seem to be covered).
Remarks,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
