On Wed, Feb 7, 2024 at 10:41 PM Peter Eisentraut <pe...@eisentraut.org> wrote: > > /tmp/cirrus-ci-build/src/include/common/hashfn_unstable.h: In function > ‘int fasthash_accum_cstring_unaligned(fasthash_state*, const char*)’: > /tmp/cirrus-ci-build/src/include/common/hashfn_unstable.h:201:20: > warning: comparison of integer expressions of different signedness: > ‘int’ and ‘long unsigned int’ [-Wsign-compare] > 201 | while (chunk_len < FH_SIZEOF_ACCUM && str[chunk_len] != '\0') > | ^ > > and a few more like that. > > I think it would be better to declare various int variables and > arguments as size_t instead. Even if you don't actually need the larger > range, it would make it more self-documenting.
Thanks for the report! I can reproduce and have pushed that change.