On Fri, Mar 1, 2024 at 9:53 AM Peter Smith <smithpb2...@gmail.com> wrote: > > Here are some review comments for v102-0001. > > > 7. > + /* > + * Return false if not all the standbys have caught up to the specified WAL > + * location. > + */ > + if (caught_up_slot_num != list_length(standby_slot_names_list)) > + return false; > > Somehow it seems complicated to have a counter of the slots as you > process then compare that counter to the list_length to determine if > one of them was skipped. > > Probably simpler just to set a 'skipped' flag set whenever you do > 'continue'... >
The other thing is do we need to continue when we find some slot that can't be processed? If not, then we can simply set the boolean flag, break the loop, and return false if the boolean is set after releasing the LWLock. The other way is we simply release lock whenever we need to skip the slot and just return false. -- With Regards, Amit Kapila.
