On Fri, Mar 22, 2024 at 2:38 PM Andres Freund <and...@anarazel.de> wrote: > I wonder if we ought to make configure warn if it sees -Werror in CFLAGS - > this is far from the first time somebody stumbling with -Werror. Including a > few quite senior hackers, if I recall correctly. We could also just filter it > temporarily and put it back at the end of configure.
I think I made this mistake at some point, but I just looked at config.log and corrected my mistake. I'm not strongly against having an explicit check for -Werror, but I think the main problem here is that the original poster didn't have a look at config.log to see what the actual problem was, and at least IME that's necessary in pretty much 100% of cases where configure fails for whatever reason. Perhaps autotools could be better-designed in that regard, but we don't necessarily want to work around every problem that can stem from that design choice in our code, either. -- Robert Haas EDB: http://www.enterprisedb.com
