Hello,

Note that, in the patch as posted, the column names are not
translatable.  In order to be translatable, the code needs to do
something like

appendPQExpBuffer(&buf,
                "  NULL AS \"%s\",\n"
                "  NULL AS \"%s\",\n"
                "  NULL AS \"%s\",\n"
                "  NULL AS \"%s\",\n",
                _("SSL Connection"),
                _("SSL Protocol"),
                _("SSL Cipher"),
                _("SSL Compression"));

instead of 

       appendPQExpBuffer(&buf,
                         "  NULL AS \"SSL Connection\",\n"
                         "  NULL AS \"SSL Protocol\",\n"
                         "  NULL AS \"SSL Cipher\",\n"
                         "  NULL AS \"SSL Compression\",\n");


Please list me as reviewer for this patch, as I provided significant
guidance before it was even posted.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/


Reply via email to