Hi hackers, I'm playing a toy static analysis checker with PostgreSQL and found a variable is missing volatile qualifier.
Best Regards, Xing
From 7084055da64d0433b09e50faff630e551c363f27 Mon Sep 17 00:00:00 2001 From: Xing Guo <higuox...@gmail.com> Date: Mon, 1 Apr 2024 21:39:04 +0800 Subject: [PATCH v1] Add missing volatile qualifier. The object pltargs is modified in the PG_TRY block (line 874) and used in the PG_CATCH block (line 881) which should be qualified with volatile. --- src/pl/plpython/plpy_exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pl/plpython/plpy_exec.c b/src/pl/plpython/plpy_exec.c index e06fde1dd9..cd71082a5f 100644 --- a/src/pl/plpython/plpy_exec.c +++ b/src/pl/plpython/plpy_exec.c @@ -689,7 +689,7 @@ PLy_trigger_build_args(FunctionCallInfo fcinfo, PLyProcedure *proc, HeapTuple *r *pltrelid, *plttablename, *plttableschema, - *pltargs = NULL, + *volatile pltargs = NULL, *pytnew, *pytold, *pltdata; -- 2.44.0