Hi,The function 'libpqrcv_check_conninfo()' returns 'void', but the comment above says that the function returns true or false.
I've attached a patch to modify the comment.
Regard, Rintaro Ikeda
diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c index 02f12f2921..851bf44fd3 100644 --- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c +++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c @@ -309,8 +309,8 @@ bad_connection: * local filesystem access to be attempted. * * If the connection string can't be parsed, this function will raise - * an error and will not return. If it can, it will return true if this - * connection string specifies a password and false otherwise. + * an error. If it can, it will do nothing if this connection string + * specifies a password and raise an error otherwise. */ static void libpqrcv_check_conninfo(const char *conninfo, bool must_use_password)