Thanks for your suggestion. I used ChatGPT to choose the wording, but
it's still difficult for me.
The new patch includes your suggestion.
On 2024-06-27 17:18, Jelte Fennema-Nio wrote:
On Thu, 27 Jun 2024 at 09:09, ikedarintarof
<[email protected]> wrote:
Thank you for your comment!
I've added the must_use_password argument. A new patch is attached.
s/whther/whether
nit: "it will do nothing" sounds a bit strange to me (but I'm not
native english). Something like this reads more natural to me:
an error. If must_use_password is true, the function raises an error
if no password is provided in the connection string. In any other case
it successfully completes.
From c01cadcb955d79ff525992985bd59736c6731abe Mon Sep 17 00:00:00 2001
From: Rintaro Ikeda <[email protected]>
Date: Thu, 27 Jun 2024 16:04:08 +0900
Subject: [PATCH] modify the commnet in libpqrcv_check_conninfo()
---
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
index 02f12f2921..4f7b69a73d 100644
--- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
+++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
@@ -309,8 +309,9 @@ bad_connection:
* local filesystem access to be attempted.
*
* If the connection string can't be parsed, this function will raise
- * an error and will not return. If it can, it will return true if this
- * connection string specifies a password and false otherwise.
+ * an error. If must_use_password is true, the function raises an error
+ * if no password is provided in the connection string. In any other case
+ * it successfully completes.
*/
static void
libpqrcv_check_conninfo(const char *conninfo, bool must_use_password)
--
2.39.3 (Apple Git-146)
