Hi Shubham, I think the v25-0001 patch only half-fixes the problems reported in my v24-0001 review.
~ Background (from the commit message): This commit enables support for the 'include_generated_columns' option in logical replication, allowing the transmission of generated column information and data alongside regular table changes. ~ The broken TAP test scenario in question is replicating from a "not-generated" column to a "generated" column. As the generated column is not on the publishing side, IMO the 'include_generated_columns' option should have zero effect here. In other words, I expect this TAP test for 'include_generated_columns = true' case should also be failing, as I wrote already yesterday: +# FIXME +# Since there is no generated column on the publishing side this should give +# the same result as the previous test. -- e.g. something like: +# ERROR: logical replication target relation "public.tab_nogen_to_gen" is missing +# replicated column: "b" ====== Kind Regards, Peter Smith. Fujitsu Australia
