Hi Michael, Michael Harris <har...@gmail.com>, 23 Ağu 2024 Cum, 13:01 tarihinde şunu yazdı:
> V2 of the patch is attached. > Thanks for updating the patch. I have a few more minor feedbacks. -ANALYZE [ ( <replaceable class="parameter">option</replaceable> [, ...] ) > ] [ <replaceable class="parameter">table_and_columns</replaceable> [, ...] ] > +ANALYZE [ ( <replaceable class="parameter">option</replaceable> [, ...] ) > ] [ [ ONLY ] <replaceable class="parameter">table_and_columns</replaceable> > [, ...] ] I believe moving "[ ONLY ]" to the definitions of table_and_columns below, as you did with "[ * ]", might be better to be consistent with other places (see [1]) + if ((options & VACOPT_VACUUM) && is_partitioned_table && ! i > nclude_children) There are also some issues with coding conventions in some places (e.g. the space between "!" and "include_children" abode). I think running pgindent would resolve such issue in most places. [1] https://www.postgresql.org/docs/16/sql-createpublication.html Regards, -- Melih Mutlu Microsoft
