> On Sep 12, 2024, at 13:39, Michael Paquier <mich...@paquier.xyz> wrote: > > External Email > > > I was looking at all that, and this is only moving code around. While > the part for heap_xlog_logical_rewrite in rewriteheap.c is a bit sad > but historical, the header cleanup in heapam.c is nice. > > Seeing heap_execute_freeze_tuple in heapam.h due to the dependency to > XLH_INVALID_XVAC and XLH_FREEZE_XVAC is slightly surprising, but the > opposite where heap_execute_freeze_tuple() would be in heapam_xlog.h > was less interesting. Just to say that I am agreeing with you here > and I have let this part as you suggested originally. > > I was wondering for a bit about the order of the functions for heap > and heap, but these are ordered in their own, which is also OK. I > have added a few more comments at the top of each subroutine for the > records to be more consistent, and applied the result. > — > Michael >
I am so glad to see that my patch got committed. Thank you a lot for it! This is my first accepted patch. It really means a lot to me. Yong
