On Mon, Jun 2, 2025 at 2:31 PM jian he <jian.universal...@gmail.com> wrote: > On Thu, May 29, 2025 at 11:06 AM Richard Guo <guofengli...@gmail.com> wrote: > > Yeah, ATPrepAlterColumnType does seem like a better place. But we > > need to ensure that ATColumnChangeRequiresRewrite sees the expanded > > version of the expression — your proposed change fails to do that. > > > > Additionally, I think we also need to ensure that the virtual > > generated columns are expanded before the expression is fed through > > expression_planner, to ensure it can be successfully transformed into > > an executable form. > > > > Hence, the attached patch.
> looks good to me. Pushed. Thanks Richard
