> the buildfarm seems to be mostly happy so far, so I've taken a quick > look at the remaining two parts. The patches still apply, but I'm > getting plenty of failures in regression tests, due to 0.0 being > replaced by -0.0.
I think we are better off fixing them locally at the moment like your patch does. We should consider to eliminate -0 globally for all floating point based datatypes later. I simplified and incorporated your change to line_interpt_line() into mine. I am not sure about normalising -0s on point_construct(). We currently allow points to be initialized with -0s. I think it is fair for us to return -0 when -x and 0 are multiplied. That is the current behavior and the behavior of the float datatypes. I adjusted the results of the new regression tests accordingly. > Another thing I noticed is the last few lines from line_interpt_line are > actually unreachable, because there's now 'else return false' branch. Which lines do you mean exactly? I don't see any being unreachable.
0001-line-fixes-v14.patch
Description: Binary data
0002-geo-tests-v10.patch.gz
Description: GNU Zip compressed data
