On Mon, Sep 01, 2025 at 02:35:56PM -0400, Peter Geoghegan wrote: > I remember that when I worked on what became commit 9b42e71376 back in > 2019 (which fixed a similar problem caused by the INCLUDE index > patch), Tom suggested that we do things this way defensively (without > being specifically aware of the _bt_getbuf hazard). That does seem > like the best approach. > > I'm a little bit worried about the added overhead of allocating an > extra BLCKSZ buffer for this. I wonder if it would make sense to use > BLCKSZ arrays of char for both of the temp pages.
Hmm. Yes, the allocation makes me a bit uneasy. Or it would be possible to just use a PGAlignedBlock here? That's already used in some code paths for page manipulations, forcing alignment. -- Michael
signature.asc
Description: PGP signature
