On Sun, Sep 14, 2025 at 11:23 PM Jeff Davis <[email protected]> wrote: > > On Sun, 2025-09-14 at 13:39 +0530, Dilip Kumar wrote: > > I tried to improve it in v2 > > Thank you. Looks good to me.
Thanks > > > > IMHO during crash recovery LocalMinRecoveryPoint and > > ControlFile->minRecoveryPoint can not initialized until we replay all > > WAL so those should never get accessed. However if XLogNeedsFlush() > > were called during the end of the recovery checkpoint it was > > accessing > > this which was wrong although it was not a live bug and this patch is > > making that more resilient. > > OK, so this will no longer be a concern after the patch (and not a live > bug before, anyway). That's my take, but I'd like to hear Melanie's thoughts on this point as she raised this concern. -- Regards, Dilip Kumar Google
