> On Mon, Sep 15, 2025 at 04:47:27PM -0500, Sami Imseih wrote: > > Just to confirm, you are saying we are unlikely to ever add a new field > > to the key. Is that correct? > > I would rather avoid that, yes.
7d85d87f4d5c35 added code to clear the padding bytes with memset in anticipation that the key could be changed in the future, in a way that padding will be introduced. So, if we are changing thoughts on this, we should add additional comments next to ``` + * NB: We assume that this struct contains no padding. ``` to enforce that the hash stored in objid should be used to support additional fields, rather than adding a field directly into the key. Will help future patch reviews/designs. -- Sami
