> On 3 Oct 2025, at 01:36, David Rowley <[email protected]> wrote: > > On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson <[email protected]> wrote: >> Another nitpick would be to remove the test for NULL in >> test_bms_make_singleton >> since that is a STRICT function, making the test for NULL superfluous code: > > I see test_random_operations() is also strict. Is it worth getting rid > of the SQL NULL checks on the inputs there too? Aka, the attached.
Indeed, but reading the code I wonder if STRICT was a mistake and the intention was to allow NULL input? That being said, the function is never called with NULL so that's mostly academic thinking. +1 for removing the NULL checks and simplifying the code. -- Daniel Gustafsson
