On Thu, Oct 16, 2025 at 4:53 PM Zhijie Hou (Fujitsu) <[email protected]> wrote:
> On Thursday, October 16, 2025 5:59 PM Amit Kapila <[email protected]> > wrote: > > > While reading through the patch, I have 2 comments in 0002 1. + ereport(LOG, + errmsg("logical replication sequence synchronization for subscription \"%s\" - batch #%d = %d attempted, %d succeeded, %d skipped, %d mismatched, %d insufficient permission, %d missing, ", + MySubscription->name, (current_index / MAX_SEQUENCES_SYNC_PER_BATCH) + 1, batch_size, + batch_succeeded_count, batch_skipped_count, batch_mismatched_count, batch_insuffperm_count, + batch_size - (batch_succeeded_count + batch_skipped_count + batch_mismatched_count + batch_insuffperm_count))); + The log message is ending with ..." %d missing, " (a trailing comma and space). 2. Also IMHO instead of just saying "missing" we can say "missing on/from publisher" so that it would be more clear. -- Regards, Dilip Kumar Google
