On Mon, Oct 27, 2025 at 09:55:38AM -0500, Nathan Bossart wrote: > /* > * DISABLE_LEADER_PARTICIPATION disables the leader's participation in > * parallel index builds. This may be useful as a debugging aid. > -#undef DISABLE_LEADER_PARTICIPATION > + *#undef DISABLE_LEADER_PARTICIPATION > */ > > IMHO we should either remove this line or move it out of the comment. > AFAICT we ordinarily don't #undef debugging stuff like this, presumably so > you can change it with compile flags.
I would put this one on a separate line, outside the comment. It's minor, still we use this style in pg_config_manual.h. See around REALLOCATE_BITMAPSETS. -- Michael
signature.asc
Description: PGP signature
