> On Oct 27, 2025, at 20:13, Aleksander Alekseev <[email protected]>
> wrote:
>
> Hi Nathan,
>
>>> Personally I don't have a strong opinion on this. We can easily add an
>>> exception for "/* ---" and "/* ===" comments if somebody believes this
>>> is a problem. I choose not to add such an exception just yet only
>>> because I don't like unnecessary exceptions :)
>>
>> +1 for adding an exception for "/* -----" style comments. I tested running
>> pgindent after applying the patch, and the first thing I noticed was all
>> these (IMHO) unnecessary changes. I don't think it helps readability, and
>> even if it did, it's arguably not worth the churn.
>
> OK, here is the corrected patch v5.
>
> --
> Best regards,
> Aleksander Alekseev
> <v5-0001-pgindent-improve-formatting-of-multiline-comments.patch>
1. I just ran the patched pgindent against a random file, then I got a lot
diffs like:
```
/*
- * Direct advancement: avoid waking non-caught up backends that
- * aren't interested in our notifications.
+ * Direct advancement: avoid waking non-caught up backends that aren't
+ * interested in our notifications.
*/
```
I am afraid that would generate a lot of noises for future reviews.
2. A typo in the patch
```
+ # Check each line except for the fist and the last one
```
fist => first
3. As you are updating pgindent, I want to report an issue, you may address in
a separate patch or just in this patch, up to you.
See this code:
```
else
/*
* fetch all the rest of the page
*/
copysize = QUEUE_PAGESIZE - curoffset;
```
In the “else” clause, there is a multiple-line comment block, and a single line
of code. Pgindent will add an empty line between “else” and the comment block,
which is weird. If the comment is one-line, then no empty line will be inserted.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
