Hi Shlok. This is a general comment about the content of these patches.
IIUC, the v25* patches currently are currently arranged like this: 0001 - New command ALTER PUBLICATION pubname RESET; 0002 - Add new command: ALTER PUBLICATION pub_name ADD ALL TABLES; - Enhance existing CREATE and the new ALTER syntax for EXCEPT tables 0003 - Enhance existing CREATE and ALTER syntax for EXCEPT col_list ~~~ IMO it is a bug that the ALTER PUBLICATION pub_name ADD/SET ALL TABLES command does not already exist as a supported command. And, that is independent of anything else you are implementing here like RESET or EXCEPT. Therefore, I think that one should be 1st in your patchset; The EXCEPT stuff then just becomes enhancements to existing syntax, which would give a cleaner separation of logic. So, I am suggesting there should be 4 patches instead of 3. e.g. SUGGESTION 0001 - New command: ALTER PUBLICATION pub_name ADD/SET ALL TABLES; 0002 - New command: ALTER PUBLICATION pubname RESET; 0003 - Enhance existing CREATE/ALTER syntax for EXCEPT tables 0004 - Enhance existing CREATE/ALTER syntax for EXCEPT col_list ====== Kind Regards, Peter Smith. Fujitsu Australia
