On Wed, Nov 19, 2025 at 9:04 AM Masahiko Sawada <[email protected]> > > Fixed, but I have a comment. I noticed minor wording inconsistencies, > > e.g., 'started' vs. 'initiated' and 'due to' vs. 'because of'. Should > > I unify these terms? > > +1
It seems the inconsistency between 'started' and 'initiated' has not been resolved. Come to think of it, since the column name is triggerd_by, I think it would be best to standardize on 'triggered'. I have attached a patch to fix this. > Thank you for updating the patch! For the v4 patch, > > @@ -808,6 +821,8 @@ heap_vacuum_rel(Relation rel, const VacuumParams params, > * visibility map (even those set all-frozen) > */ > vacrel->aggressive = true; > + pgstat_progress_update_param(PROGRESS_VACUUM_MODE, > + PROGRESS_VACUUM_MODE_AGGRESSIVE); > skipwithvm = false; > } > > I think we can update the mode to 'normal' or 'aggressive' instead of > switching 'normal' to 'aggressive' here. You're right, thanks. > I've made minor changes to the v4 patch and attached the updated > patch. I'm going to push the patch unless there are other review > comments. Please review the patch. Apart from the corrections mentioned above, there were no issues. Thank you very much for your thorough review. -- Best regards, Shinya Kato NTT OSS Center
v6-0001-Add-mode-and-triggered_by-columns-to-pg_stat_prog.patch
Description: Binary data
