On Thu, Dec 4, 2025 at 8:30 PM Shinya Kato <[email protected]> wrote: > > Thank you for the review! > > On Thu, Dec 4, 2025 at 9:15 AM Masahiko Sawada <[email protected]> wrote: > > I've attached a small change to simplify the 0001 patch. Please review it. > > LGTM, and I've updated in v9 patches. > > > Here are a few comments: > > > > + <listitem> > > + <para> > > + <literal>manual</literal>: The analyze was started by an explicit > > > > For consistency with "started_by" in pg_stat_progress_vacuum, I think > > it's better to start with "The operation was started by". > > I think "started_by" in pg_stat_progress_vacuum uses "The vacuum was > started by ...".
I missed that, you're right. > > > --- > > + <command>ANALYZE</command> or <command>VACUUM (ANALYZE)</command> > > + command. > > > > How about using "... or VACUUM with the ANALYZE option"? > > Agreed, I've fixed it. Thank you for updating the patch! The patches look good to me, so I'm going to push them if there are not further review comments and objections. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
