Hi Stephen, While hacking another patch, I have noticed that triggerring multiple times in a row installcheck on test_pg_dump results in a failure because it is missing clean up actions on the role regress_dump_test_role. Roles are shared objects, so I think that we ought to not let traces of it when doing any regression tests on a running instance.
Attached is a patch to clean up things. Thanks, -- Michael
diff --git a/src/test/modules/test_pg_dump/expected/test_pg_dump.out b/src/test/modules/test_pg_dump/expected/test_pg_dump.out index c9bc6f7625..8d7b0ec926 100644 --- a/src/test/modules/test_pg_dump/expected/test_pg_dump.out +++ b/src/test/modules/test_pg_dump/expected/test_pg_dump.out @@ -92,3 +92,12 @@ ALTER EXTENSION test_pg_dump DROP SERVER s0; ALTER EXTENSION test_pg_dump DROP TABLE test_pg_dump_t1; ALTER EXTENSION test_pg_dump DROP TYPE test_pg_dump_e1; ALTER EXTENSION test_pg_dump DROP VIEW test_pg_dump_v1; +-- Clean up +DROP EXTENSION test_pg_dump; +DROP SCHEMA test_pg_dump_s1; +DROP MATERIALIZED VIEW test_pg_dump_mv1; +DROP FOREIGN TABLE ft1; +DROP SERVER s0; +DROP TYPE test_pg_dump_e1; +DROP FUNCTION test_pg_dump(integer); +DROP ROLE regress_dump_test_role; diff --git a/src/test/modules/test_pg_dump/sql/test_pg_dump.sql b/src/test/modules/test_pg_dump/sql/test_pg_dump.sql index e463dec404..2ceb84d223 100644 --- a/src/test/modules/test_pg_dump/sql/test_pg_dump.sql +++ b/src/test/modules/test_pg_dump/sql/test_pg_dump.sql @@ -105,3 +105,13 @@ ALTER EXTENSION test_pg_dump DROP SERVER s0; ALTER EXTENSION test_pg_dump DROP TABLE test_pg_dump_t1; ALTER EXTENSION test_pg_dump DROP TYPE test_pg_dump_e1; ALTER EXTENSION test_pg_dump DROP VIEW test_pg_dump_v1; + +-- Clean up +DROP EXTENSION test_pg_dump; +DROP SCHEMA test_pg_dump_s1; +DROP MATERIALIZED VIEW test_pg_dump_mv1; +DROP FOREIGN TABLE ft1; +DROP SERVER s0; +DROP TYPE test_pg_dump_e1; +DROP FUNCTION test_pg_dump(integer); +DROP ROLE regress_dump_test_role;
signature.asc
Description: PGP signature
