Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Michael Paquier <mich...@paquier.xyz> writes: > > While hacking another patch, I have noticed that triggerring multiple > > times in a row installcheck on test_pg_dump results in a failure because > > it is missing clean up actions on the role regress_dump_test_role. > > Roles are shared objects, so I think that we ought to not let traces of > > it when doing any regression tests on a running instance. > > > Attached is a patch to clean up things. > > I'm confused. Isn't the point of that script exactly to create a modified > extension for testing pg_dump with? > > What I'd do is leave the final state as-is and add a "drop role if exists" > at the start, similar to what some of the core regression tests do.
I've not followed this thread but based on Tom's response, I agree with his suggestion of what to do here. Thanks! Stephen
signature.asc
Description: PGP signature
