Mihail Nikalayeu <[email protected]> wrote: > Some comments for 0003: > > > /* allocate in transaction context */ > It may be any context now, because it is a function now.
Inaccuracy not introduced by REPACK, but I think it's o.k. if the next version of this patch will remove the comment. > > result = CopySnapshot(snapshot); > > > /* Restore the original values so the source is intact. */ > > snapshot->xip = oldxip; > > snapshot->xcnt = oldxcnt; > > I think it is worth to call pfree(newxip) here. ok > > "This difference does has no impact" > > should be "This difference has no impact"? Right, thanks. -- Antonin Houska Web: https://www.cybertec-postgresql.com
