On 1/14/26 8:22 AM, Steven Niu wrote:
I agree that you are correct for now. But in future, the IoMethod may have new member. Then we have to process it.How about change to like this: + #else + if (*newval == IOMETHOD_IO_URING) + { + GUC_check_errdetail("io_uring not enabled."); + return false; + }
No, that would be incorrect. It would not even compile. IOMETHOD_IO_URING is not even defined if we do not compile with liburing enabled. You can try it out yourself by compiling PostgreSQL without io_uring support and then try to enable it. You will get an error and that code will never be reached.
Andreas
