References: <[email protected]> <caa4ek1jtsn2ow4+xpmoovfyf5lg+zdbq8lmak1h_mcd5ssu...@mail.gmail.com> <CA+TgmobgPuxLWMbTzBE72yKDQJTXpCnGjtCN3v5N=u_f3ud...@mail.gmail.com> <[email protected]> <CALDaNm0Ro-Z0JdsuZxEYRQxqdOOY2U3vRrPtRU=re4cb8ee...@mail.gmail.com> <[email protected]> <caa4ek1lsvodwq5ac92q2puhrigqs68bzmumybc-d7d39mcv...@mail.gmail.com> <[email protected]> <[email protected]> <CAHGQGwG82P4s6tmYK=aEm-T7QfGJBZvXo=wzfckmkffsx6d...@mail.gmail.com> <cahgqgwhq0hp8zzvxarrvoqd6zjswsto8e_4qqpn5x3befez...@mail.gmail.com> User-Agent: mu4e 1.12.12; emacs 29.3 Hi, Fujii
Date: Thu, 05 Feb 2026 12:06:45 +0800 On Thu, 05 Feb 2026 at 09:33, Fujii Masao <[email protected]> wrote: > On Thu, Oct 23, 2025 at 5:19 PM Fujii Masao <[email protected]> wrote: >> >> On Mon, Jul 14, 2025 at 10:27 PM Fujii Masao >> <[email protected]> wrote: >> > I've attached the rebased patches. >> >> Attached are the rebased versions of the patches. > > I've rebased the patches again. > Thanks for updating the patches. I have one small comment on v4-0002: @@ -104,6 +105,7 @@ typedef struct SubOpts int32 maxretention; char *origin; XLogRecPtr lsn; + char *wal_receiver_timeout; } SubOpts; According to the comment above the SubOpts struct: Structure to hold a bitmap representing the user-provided CREATE/ALTER SUBSCRIPTION command options and the parsed/default values of each of them. Since `wal_receiver_timeout` is a GUC-style interval value (typically stored as integer milliseconds), wouldn't it be better to use an int32 here instead of a string? > Regards, > > -- > Fujii Masao > > [2. text/x-diff; v4-0001-Make-GUC-wal_receiver_timeout-user-settable.patch]... > > [3. text/x-diff; > v4-0002-Add-per-subscription-wal_receiver_timeout-setting.patch]... -- Regards, Japin Li ChengDu WenWu Information Technology Co., Ltd.
