On Fri, Feb 6, 2026 at 3:44 PM Japin Li <[email protected]> wrote: > 1. > Typo, s/timeeout/timeout/g.
Fixed. Thanks for the review! > 2. > The comment mentions skipping only "-1". > Since we already use strcmp(... , "-1") later in the code, wouldn't it be > better to use the same check here too? With this approach, a command like CREATE SUBSCRIPTION using a wal_receiver_timeout value such as '-1 ' (i.e., -1 followed by whitespace) would fail, since it would not be interpreted as -1. I don't think that's desirable behavior. So it would be better to use parse_int() so that such input is handled correctly. Regards, -- Fujii Masao
v5-0001-Make-GUC-wal_receiver_timeout-user-settable.patch
Description: Binary data
v5-0002-Add-per-subscription-wal_receiver_timeout-setting.patch
Description: Binary data
