> On Dec 25, 2025, at 11:34, Chao Li <[email protected]> wrote: > > > >> On Dec 25, 2025, at 11:12, Chao Li <[email protected]> wrote: >> >> Hi Hackers, >> >> I noticed this error while working on [1]. >> >> In BufFile, the fields is claimed as an array: >> ``` >> struct BufFile >> { >> File *files; /* palloc'd array with numFiles entries */ >> ``` >> >> However, it’s allocated by palloc_object(): >> ``` >> file->files = palloc_object(File); >> ``` >> >> And reallocated by repalloc(): >> ``` >> file->files = (File *) repalloc(file->files, >> (file->numFiles + 1) * sizeof(File)); >> ``` >> >> This trivial patch just changes to use palloc_array/repalloc_array, which >> makes the intent clearer. >> >> Best regards, >> -- >> Chao Li (Evan) >> HighGo Software Co., Ltd. >> https://www.highgo.com/ >> >> >> >> >> <v1-0001-Use-palloc_array-repalloc_array-for-BufFile-file-.patch> > > > Sorry for missing the reference of [1]: > > [1] https://postgr.es/m/[email protected] > > Best regards, > -- > Chao Li (Evan) > HighGo Software Co., Ltd. > https://www.highgo.com/ >
PFA v2: * Rebased * Updated the commit message Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
v2-0001-buffile-fix-misuse-of-palloc_object-and-use-array.patch
Description: Binary data
