> On 6 Mar 2026, at 08:34, 慈超云 <[email protected]> wrote: > > Hi hackers, > > I found that the is_error parameter of the TeardownHistoricSnapshot() > function is not actually used anywhere in the code. > This parameter was introduced in commit > b89e151054a05f0f6d356ca52e3b725dd0505e53 as part of the logical decoding > feature, but has never been used. The function just sets two global pointers > to NULL regardless of the parameter value.
It is indeed unused, but given that it exists and the callers set it appropriately it could be a pretty valuable debugging aid when attaching, or adding logging, to TeardownHistoricSnapshot. Compilers are smart enough to take care of this for us so there seems to be little value in removing this (apart from silencing AI tools but that's not something we optimize for). -- Daniel Gustafsson
