On Tue, Mar 17, 2026 at 7:22 AM Peter Smith <[email protected]> wrote: > > On Mon, Mar 16, 2026 at 8:39 PM Amit Kapila <[email protected]> wrote: > > > > On Mon, Mar 16, 2026 at 2:08 PM Peter Smith <[email protected]> wrote: > > > > I think we can make a separate case for ADD/DROP rather than tie it > > along with this patch. For example, DROP ALL Tables could be used for > > ALL TABLES and non-ALL TABLES publication, for later it could mean to > > drop all the publicized tables and for earlier it just toggles the > > flag. > > > > The basic expected SET/ADD/DROP behaviours are already very clear; > It's just that they are not yet implemented for "ALL TABLES" and "ALL > SEQUENCES". Ideally, those would be prerequisites for this EXCEPT > patch. > > If they are done separately later, then it means in the interim, there > will be some publication clause combinations that can lead to dead > ends, where the user would be unable to modify the publication as they > want without dropping and recreating it. > > Maybe that is OK. Perhaps having functionality gaps doesn't matter as > much as I think it does:
Possible. > - e.g1. The FOR ALL SEQUENCES has existed for some months, and we > cannot use ALTER to change it. Nobody complained? > Isn't the same true FOR ALL TABLES which is there from the time logical replication is introduced? So, we tried to follow the same for ALL SEQUENCES case. We can do extensions of the proposed or existing syntaxes based on the user input in future. If we try to find all possible ways to set/reset all the options provided for publications/subscriptions, we may find a few more. At this stage, we want one way for users to change the EXCEPT list which the proposed patch is providing. > - e.g2. For years, it's been impossible to convert an "empty" > publication into a FOR ALL TABLES publication. Nobody complained? > Right, so that indicates, there is no immediate need to support all kinds of syntaxes. > OTOH, doing them in the right order is preferable to avoid churning > the ALTER PUBLICATION docs page synopsis/description. > That is a small price to pay as compared to building/maintaining more variants when we don't see field demand for the same. -- With Regards, Amit Kapila.
