On Tue, Mar 17, 2026 at 9:21 PM vignesh C <[email protected]> wrote:
>
>
> These comments are addressed in the v65 version patch attached. Also
> the comments from [1] have been addressed in this.
> [1] -
> https://www.postgresql.org/message-id/CAA4eK1%2BmSpCzj%2BB2PW_68DJpXHA0KMgT9Nrz9P83_c1vdKya8g%40mail.gmail.com
>
Thanks, few trivial things:
1)
In the doc we talk about the first two variants and then the third
variant. IIUC, you need to change variants to match the new details,
i.e.
Change these:
ALTER PUBLICATION name ADD publication_object [, ...]
ALTER PUBLICATION name SET { publication_object [, ...] |
publication_all_object [, ... ] }
ALTER PUBLICATION name DROP publication_drop_object [, ...]
to:
ALTER PUBLICATION name ADD publication_object [, ...]
ALTER PUBLICATION name DROP publication_drop_object [, ...]
ALTER PUBLICATION name SET { publication_object [, ...] |
publication_all_object [, ... ] }
or change the details to match variants.
2)
+ /*
+ * Publications contain either only EXCEPT entries or only included
+ * tables. So checking a single tuple is sufficient.
+ */
+ result = !pubrel->prexcept;
The command looks slightly misleading, can we please change it to:
For any publication, pg_publication_rel contains either only EXCEPT
entries or only explicitly included tables. Therefore, examining the
first tuple is sufficient to determine table inclusion.
3)
publication_add_relation() contains repetitive comments at both the
beginning and end of the function regarding invalidation of EXCEPT
tables. We can keep the first one (slightly rephrased, if needed, to
incorporate the second) and remove the latter.
thanks
Shveta
