Dear Gyan,
Can you rebase the patch because 0001 is now pushed?
Also, below contains my minor comments.
01.
Found that pg_log_generic_v() has some prefix but internal_log_file_write()
does not.
It means output strings are not the same. For example, on terminal:
```
pg_createsubscriber: error: standby server is running
pg_createsubscriber: hint: Stop the standby server and try again.
```
But on log file:
```
standby server is running
Stop the standby server and try again.
```
It's because pg_log_generic_v() has the format like below. I.e., the program
name
is printed at the begining, and some prefix also exists in some cases.
${program name}: {error: |warning: |detail: |hint: } content
I cannot find such a difference on pg_upgrade: no prefix exists in any cases.
So, what should be here? My preference is to basically follow pg_log_generic_v()
But remove the program name. How about others?
02.
Can we check the permission of generated directory in the test?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
