On Tue, 31 Mar 2026 at 06:00, Peter Smith <[email protected]> wrote: > > Hi Vignesh. > > Some review comments for patch v4-0001. > > ====== > doc/src/sgml/ref/alter_publication.sgml > > 1. > - [ ONLY ] <replaceable class="parameter">table_name</replaceable> [ * ] > + TABLE <replaceable class="parameter">table_object</replaceable> [, ... ] > + > +<phrase>and <replaceable class="parameter">table_object</replaceable> > is:</phrase> > + > + [ ONLY ] <replaceable class="parameter">table_name</replaceable> [ * ] > > With the introduction of 'table_object' I expected that > 'table_and_columns' and 'publication_drop_object' would also make use > of it. Why not? > > ====== > doc/src/sgml/ref/create_publication.sgml > > 2. > - [ ONLY ] <replaceable class="parameter">table_name</replaceable> [ * ] > + TABLE <replaceable class="parameter">table_object</replaceable> [, ... ] > + > +<phrase>and <replaceable class="parameter">table_object</replaceable> > is:</phrase> > + > + [ ONLY ] <replaceable class="parameter">table_name</replaceable> [ * ] > > With the introduction of 'table_object' I expected that > 'table_and_columns' would also make use of it. Why not? >
Thanks for the comments. This is addressed in the 002 patch attached. The 001 patch has the rebased version of the patch at [1] to fix Peter's earlier comments at [2]. [1] - https://www.postgresql.org/message-id/CALDaNm0mYT55pjdyN-yY%3D5dSOfMVx307CtP3xYqzWVa0MPRtLQ%40mail.gmail.com [2] - https://www.postgresql.org/message-id/CAHut%2BPvw-XNBnW-ymGdWpLxaEime7_EdOihcUheGyZvw73kcgg%40mail.gmail.com Regards, Vignesh-
0002-Reuse-table_object-in-publication-command-syntax.patch
Description: Binary data
0001-Fix-few-issues-in-commit-fd366065e0.patch
Description: Binary data
