Hi, On 2026-03-30 18:37:27 -0400, Melanie Plageman wrote: > On Mon, Mar 30, 2026 at 3:14 PM Melanie Plageman > <[email protected]> wrote: > > > > On Mon, Mar 30, 2026 at 3:00 PM Alexander Lakhin <[email protected]> > > wrote: > > > > > > As copperhead showed [1], tests added in 020c02bd9 fail when postgres is > > > built without --enable-cassert. I've reproduced the failure locally with: > > > > Yes, it's because read_buffers() (in test_aio.c) uses > > operation->nblocks and that's only intialized for buffer hits in > > assert builds. The test code could just use the correctly initialized > > nblocks out parameter. > > Fix was a little more invasive than that. Looks like we were using > operation in more places than I thought. See attached.
Looks good to me. Will you push? Greetings, Andres
