On Tue, Mar 31, 2026 at 8:43 AM Andres Freund <[email protected]> wrote: > > Looks good to me. > > Will you push?
I was going to push but then Bilal asked me off-list if there was some reason not to set the members of ReadBuffersOperation outside of assert builds. I agree with him that it seems like a future user of StartReadBuffersImpl() could make this same mistake. Both of us vaguely recall this being done for performance reasons. Before committing this test change, I wanted to confirm that we don't want to modify the actual prod code the way he does in [1]. - Melanie [1] https://www.postgresql.org/message-id/CAN55FZ2-bKNKmMSRDx1xH3SyqwBVMZ8HFG2YNipQ7LCdKm7eKA%40mail.gmail.com
