On 14.01.26 20:08, Alexandra Wang wrote:
Hi Kirill,
On Wed, Jan 14, 2026 at 5:04 AM Kirill Reshke <[email protected]
<mailto:[email protected]>> wrote:
> On Wed, 14 Jan 2026 at 12:59, Alexandra Wang
> <[email protected] <mailto:[email protected]>>
wrote:
> >
> > Hi Peter,
> >
> > Thanks for the review!
> >
> > I've attached v23.
> >
> > 0001: Implement read-only dot notation for hstore.
> > 0002: a small refactor that can be squashed with 0003.
> > 0003: Implement read-only dot notation for jsonb.
>
>
> Hi!
>
> In 0002
> > + * jsonPathFromParseResult() does second pass turning AST into binary
> * representation of jsonpath.
> */
>
> Is it "does a second pass" and "into a binary representation" ?
Thanks for the review! I’ve attached v24, which addresses your
feedback by updating the comments in 0002. 0001 and 0003 remain
unchanged from v23.
Given the ongoing discussion about json array subscripting semantics
[0], which I think is a prerequisite for this, I'm putting this patch
set on hold as Returned with feedback in the commitfest. It can be
reopened when work is ready to continue.
[0]:
https://www.postgresql.org/message-id/flat/CAK98qZ1P_edO9hZJVMuUpnXjN-9H=dz2zuj-06g5qw9cmjl...@mail.gmail.com
